On 06/03/2023 11:06, Konrad Dybcio wrote: > > > On 6.03.2023 09:57, Krzysztof Kozlowski wrote: >> On 04/03/2023 16:55, Konrad Dybcio wrote: >>> Since the DSI autodetection is bound to work correctly on 6115 now, >>> switch to using the correct per-SoC + generic fallback compatible >>> combo. >>> >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> >>> --- >>> .../devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml | 8 +++++++- >>> 1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml >>> index 2491cb100b33..605b1f654d78 100644 >>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml >>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml >>> @@ -40,7 +40,13 @@ patternProperties: >>> type: object >>> properties: >>> compatible: >>> - const: qcom,dsi-ctrl-6g-qcm2290 >>> + oneOf: >>> + - items: >>> + - const: qcom,sm6115-dsi-ctrl >>> + - const: qcom,mdss-dsi-ctrl >> >> Does it actually work? You did not define qcom,sm6115-dsi-ctrl in >> dsi-controller-main? > Check the "Depends on" in the cover letter. > Then it looks like it should be squashed with that patch. Why adding new compatible in multiple steps? Best regards, Krzysztof