On 07/03/2023 07:41, Jack Zhu wrote: > > > On 2023/3/3 16:47, Krzysztof Kozlowski wrote: >> On 02/03/2023 10:19, jack.zhu wrote: >>> Add DT binding document for Starfive MIPI CSI2 receiver >> >> Ehh... you have entire commit msg to explain what you do here. Yet there >> is nothing mentioning that you actually have Cadence MIPI CSI here. >> >> Since you decided to add new bindings, you receive review matching new >> bindings. I don't think this is correct approach (duplicated bindings), >> but could work for me. However how are you going to solve all the points >> of my review? > > Maybe I don't need to add the CSI yaml file, since it already exists on the Linux mainline. If you add *only* new compatible, you do not need new binding. If you add any new properties, then depends, but old binding anyway would need conversion from TXT. Best regards, Krzysztof
