On 2023/3/2 17:39, Andreas Schwab wrote: > drivers/clocksource/timer-starfive.c:117:13: error: conflicting types for 'timer_shutdown'; have 'void(struct starfive_clkevt *)' > 117 | static void timer_shutdown(struct starfive_clkevt *clkevt) > | ^~~~~~~~~~~~~~ > In file included from ./include/linux/workqueue.h:9, > from ./include/linux/srcu.h:21, > from ./include/linux/notifier.h:16, > from ./include/linux/clk.h:14, > from drivers/clocksource/timer-starfive.c:12: > ./include/linux/timer.h:188:12: note: previous declaration of 'timer_shutdown' with type 'int(struct timer_list *)' > 188 | extern int timer_shutdown(struct timer_list *timer); > | ^~~~~~~~~~~~~~ > Oh, this timer_shutdown(struct timer_list *timer) function was not available in 6.1-rc5 which this patchset was base on. And in the new version, it's the same name as my own function. I will change the name of this function. Best regards, Xingyu Wu
