On 06/03/2023 07:04, Chunyan Zhang wrote:
> Add basic support for Unisoc's UMS512, with this patch,
> the board ums512-1h10 can run into console.
>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@xxxxxxxxxx>
> ---
> Changes since V2:
> * Removed redundant gpio.h from ums512-1h10.dts
>
> Changes since v1:
> * Addressed comments:
> - Removed earlycon bootargs;
> - Moved up gic reg as second property;
> - Moved two sdio nodes under to the apb bus node;
> - Renamed node name of all fixed clocks;
> - Fixed warnings reported by dtbs_check.
Please always mention under --- why you do not send a binding for new
board compatible.
> ---
> arch/arm64/boot/dts/sprd/Makefile | 3 +-
> arch/arm64/boot/dts/sprd/ums512-1h10.dts | 61 ++
> arch/arm64/boot/dts/sprd/ums512.dtsi | 911 +++++++++++++++++++++++
> 3 files changed, 974 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm64/boot/dts/sprd/ums512-1h10.dts
> create mode 100644 arch/arm64/boot/dts/sprd/ums512.dtsi
>
(...)
};
> +
> + apb@70000000 {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x0 0x70000000 0x10000000>;
> +
> + uart0: serial@0 {
> + compatible = "sprd,ums512-uart",
> + "sprd,sc9836-uart";
> + reg = <0x0 0x100>;
> + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&ext_26m>;
> + status = "disabled";
> + };
> +
> + uart1: serial@100000 {
> + compatible = "sprd,ums512-uart",
> + "sprd,sc9836-uart";
> + reg = <0x100000 0x100>;
> + interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&ext_26m>;
> + status = "disabled";
> + };
> +
> + sdio0: sdio@1100000 {
Isn't the node name required to be "mmc"?
> + compatible = "sprd,sdhci-r11";
> + reg = <0x1100000 0x1000>;
> + interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
> + clock-names = "sdio", "enable";
> + clocks = <&ap_clk CLK_SDIO0_2X>,
> + <&apapb_gate CLK_SDIO0_EB>;
> + assigned-clocks = <&ap_clk CLK_SDIO0_2X>;
> + assigned-clock-parents = <&pll1 CLK_RPLL>;
> + status = "disabled";
> + };
> +
> + sdio3: sdio@1400000 {
Same problem.
Best regards,
Krzysztof
