> On 5 Mar 2023, at 5:30 pm, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 05/03/2023 14:20, Christian Hewitt wrote: >> BananaPi M2S ships in Amlogic S922X and A311D variants with the >> following common specifications: >> > (...) > >> + >> + leds { >> + compatible = "gpio-leds"; >> + >> + blue { > > led-0 > > Does not look like you tested the DTS against bindings. Please run `make > dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst > for instructions). I’m building everything in a cross-compile build system that doesn’t allow this to be done without a problem amount of hoop jumping. I need to work on another arrangement to do this testing (work-in-progress). Thanks for the input. Christian >> + color = <LED_COLOR_ID_BLUE>; >> + function = LED_FUNCTION_STATUS; >> + gpios = <&gpio_ao GPIOAO_7 GPIO_ACTIVE_LOW>; >> + linux,default-trigger = "heartbeat"; >> + }; >> + >> + green { > > led-1 > >> + color = <LED_COLOR_ID_GREEN>; >> + function = LED_FUNCTION_STATUS; >> + gpios = <&gpio_ao GPIOAO_2 GPIO_ACTIVE_LOW>; >> + }; > > Best regards, > Krzysztof >