On Tue, 28 Feb 2023, Jakob Hauser wrote: > The charger state mask RT5033_CHG_STAT_MASK should be 0x30 [1][2]. > > The high impedance mask RT5033_RT_HZ_MASK is actually value 0x02 [3] and is > assosiated to the RT5033 CHGCTRL1 register [4]. Accordingly also change > RT5033_CHARGER_HZ_ENABLE to 0x02 to avoid the need of a bit shift upon > application. > > For input current limiting AICR mode, the define for the 1000 mA step was > missing [5]. Additionally add the define for DISABLE option. Concerning the > mask, remove RT5033_AICR_MODE_MASK because there is already > RT5033_CHGCTRL1_IAICR_MASK further up. They are redundant and the upper one > makes more sense to have the masks of a register colleted there as an > overview. > > [1] https://github.com/msm8916-mainline/linux-downstream/blob/GT-I9195I/drivers/battery/rt5033_charger.c#L669-L682 > [2] https://github.com/torvalds/linux/blob/v6.0/include/linux/mfd/rt5033-private.h#L59-L62 > [3] https://github.com/msm8916-mainline/linux-downstream/blob/GT-I9195I/include/linux/battery/charger/rt5033_charger.h#L44 > [4] https://github.com/msm8916-mainline/linux-downstream/blob/GT-I9195I/drivers/battery/rt5033_charger.c#L223 > [5] https://github.com/msm8916-mainline/linux-downstream/blob/GT-I9195I/drivers/battery/rt5033_charger.c#L278 > > Signed-off-by: Jakob Hauser <jahau@xxxxxxxxxxxxxx> > --- > include/linux/mfd/rt5033-private.h | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones <lee@xxxxxxxxxx> -- Lee Jones [李琼斯]
