On 03/03/2023 18:37, Neil Armstrong wrote: > Add support for both the BananaPi BPI-CM4 module and the BananaPi > baseboard which is comnpatible with the RaspberryPi CM4IO baseboard. > > The BananaPi BPI-CM4 module follows the CM4 specifications at [1], > but with a single HDMI port and a since DSI output. > (...) > + sdio_pwrseq: sdio-pwrseq { > + compatible = "mmc-pwrseq-simple"; > + reset-gpios = <&gpio GPIOAO_6 GPIO_ACTIVE_LOW>; > + clocks = <&wifi32k>; > + clock-names = "ext_clock"; > + }; > + > + emmc_1v8: regulator-emmc_1v8 { No underscores in node names. > + compatible = "regulator-fixed"; > + regulator-name = "EMMC_1V8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vddao_3v3>; > + regulator-always-on; > + }; > + > + dc_in: regulator-dc-in { > + compatible = "regulator-fixed"; > + regulator-name = "DC_IN"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-always-on; > + }; > + > Best regards, Krzysztof