On 03/03/2023 16:14, David Yang wrote: > Add CRG driver for Hi3798MV100 SoC. CRG (Clock and Reset Generator) module > generates clock and reset signals used by other module blocks on SoC. > > Signed-off-by: David Yang <mmyangfl@xxxxxxxxx> > --- > .../devicetree/bindings/clock/hisi-crg.txt | 2 + > drivers/clk/hisilicon/crg-hi3798.c | 193 ++++++++++++++++-- > include/dt-bindings/clock/histb-clock.h | 11 + No. Don't mix bindings and code. Run checkpatch - you should get warnings for this (and such you must fix, not ignore). Best regards, Krzysztof
