On 02/03/2023 13:57, Shradha Todi wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx] >> Sent: 16 February 2023 16:29 >> To: Shradha Todi <shradha.t@xxxxxxxxxxx>; lpieralisi@xxxxxxxxxx; >> kw@xxxxxxxxx; robh@xxxxxxxxxx; bhelgaas@xxxxxxxxxx; >> krzysztof.kozlowski+dt@xxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; >> jingoohan1@xxxxxxxxx; Sergey.Semin@xxxxxxxxxxxxxxxxxxxx; >> lukas.bulwahn@xxxxxxxxx; hongxing.zhu@xxxxxxx; tglx@xxxxxxxxxxxxx; >> m.szyprowski@xxxxxxxxxxx; jh80.chung@xxxxxxxxxx; >> pankaj.dubey@xxxxxxxxxxx >> Cc: linux-pci@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm- >> kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux- >> kernel@xxxxxxxxxxxxxxx >> Subject: Re: [PATCH 02/16] PCI: exynos: Rename Exynos PCIe driver to >> Samsung PCIe >> >> On 16/02/2023 11:55, Krzysztof Kozlowski wrote: >>> On 14/02/2023 13:13, Shradha Todi wrote: >>>> The current PCIe controller driver is being used for Exynos5433 SoC >>>> only. In order to extend this driver for all SoCs manufactured by >>>> Samsung using DWC PCIe controller, rename this driver and make it >>>> Samsung specific instead of any Samsung SoC name. >>>> >>>> Signed-off-by: Shradha Todi <shradha.t@xxxxxxxxxxx> >>>> --- >>>> MAINTAINERS | 4 +- >>>> drivers/pci/controller/dwc/Kconfig | 6 +- >>>> drivers/pci/controller/dwc/Makefile | 2 +- >>>> drivers/pci/controller/dwc/pci-samsung.c | 443 >>>> +++++++++++++++++++++++ >>> >>> Rename missing. I am anyway not sure if this is good. What's wrong >>> with old name? >> >> OK, looking a bit at your further patches - doesn't it make sense to split a bit >> the driver? Maybe keep the core as pci-samsung, but some other parts in >> pci-exynso5433? >> > > Ok agreed. So here is what I am planning, keeping in mind the next set of platform support which I am planning to send out (say FSD, ARTPEC-v8): > 1: We will move samsung pci driver inside dwc/samsung/ I don't think we need one more directory... > 2: pci-samsung.c shall contain common APIs, helper functions, etc > 3: Platform specific driver will have their own files such as pcie-exynos.c, pcie-fsd.c, pcie-artpec-v8.c This sounds reasonable, although depends whether common driver part is more or less common. If it is more common, then you will need only one pci_driver and it should be in common object. > Let me know what you think of this. > I am not very keen on renaming Exynos SoC file as pcie-exyons5433.c as in future we may end up adding PCIe support for other Exynos which being > in same family (Exynos Series) will be very similar in design. Custom ASIC (manufactured by Samsung Foundry) is primarily driven by various > vendors and will have separate design in terms of integration of IPs in SoC and we need to have support for all such SoCs manufactured under Samsung umbrella. Best regards, Krzysztof
