On 02/03/2023 10:19, jack.zhu wrote: > This patch adds user space interfaces for ISP. Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 Why this is a separate commit? User-space API is usually added with its implementation. Otherwise how does your code even compile? Best regards, Krzysztof