On 02/03/2023 17:08, AngeloGioacchino Del Regno wrote: > Il 02/03/23 15:12, Yassine Oudjana ha scritto: >> From: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx> >> >> Several DT bindings of MediaTek display blocks make unnecessary use of >> "oneOf" and "items". Remove them and replace them with enums where >> necessary. >> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.yaml >> index 7d7cc1ab526b..52f233fe1c0f 100644 >> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.yaml >> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.yaml >> @@ -20,9 +20,7 @@ description: | >> >> properties: >> compatible: >> - oneOf: >> - - items: >> - - const: mediatek,mt8173-disp-wdma >> + const: mediatek,mt8173-disp-wdma >> > > This is present on all MediaTek SoCs - literally. The issue is that the driver > currently does not support command mode panels for real, so this binding is... > ...well, somehow in forgotten-land... > > I would hope that command mode panels get implemented soon(er-than-later), but > I'll leave the choice to you and Krzysztof - I'm only providing the information > here. :-) Yep, if you predict now that oneOf sooner or later will come back to these, just keep it. Does not hurt much and later re-introducing it makes patch much more difficult to read. Therefore I prefer to have unused oneOf than later a patch which introduces new compatible and re-indents old one (so unneeded diff changes). Best regards, Krzysztof
