On Thu, Mar 02, 2023 at 12:20:18PM +0000, Mark Brown wrote: > On Thu, Mar 02, 2023 at 12:55:03PM +0100, richard.leitner@xxxxxxxxx wrote: > > > + max9867->mclk = devm_clk_get(&i2c->dev, "mclk"); > > + if (IS_ERR(max9867->mclk)) > > + return PTR_ERR(max9867->mclk); > > + ret = clk_prepare_enable(max9867->mclk); > > + if (ret < 0) > > + dev_err(&i2c->dev, "Failed to enable MCLK: %d\n", ret); > > + > > Nothing ever disables the clock - we need a disable in the remove path > at least. Sure. Sorry for missing that. I will send a v2 later today. regards;rl