> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Thursday, February 16, 2023 4:38 PM > To: Shradha Todi <shradha.t@xxxxxxxxxxx>; lpieralisi@xxxxxxxxxx; > kw@xxxxxxxxx; robh@xxxxxxxxxx; bhelgaas@xxxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; > jingoohan1@xxxxxxxxx; Sergey.Semin@xxxxxxxxxxxxxxxxxxxx; > lukas.bulwahn@xxxxxxxxx; hongxing.zhu@xxxxxxx; tglx@xxxxxxxxxxxxx; > m.szyprowski@xxxxxxxxxxx; jh80.chung@xxxxxxxxxx; > pankaj.dubey@xxxxxxxxxxx > Cc: linux-pci@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 09/16] PCI: samsung: Make common appl readl/writel > functions > > On 14/02/2023 13:13, Shradha Todi wrote: > > Common application logic register read and write functions used for > > better readability. > > > > Signed-off-by: Shradha Todi <shradha.t@xxxxxxxxxxx> > > --- > > drivers/pci/controller/dwc/pci-samsung.c | 54 > > ++++++++++++------------ > > 1 file changed, 27 insertions(+), 27 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pci-samsung.c > > b/drivers/pci/controller/dwc/pci-samsung.c > > index be0177fcd763..e6e2a8ab4403 100644 > > --- a/drivers/pci/controller/dwc/pci-samsung.c > > +++ b/drivers/pci/controller/dwc/pci-samsung.c > > @@ -79,63 +79,63 @@ static void exynos_pcie_deinit_clk_resources(struct > samsung_pcie *sp) > > clk_bulk_disable_unprepare(sp->clk_cnt, sp->clks); } > > > > -static void exynos_pcie_writel(void __iomem *base, u32 val, u32 reg) > > +static void samsung_pcie_appl_writel(struct samsung_pcie *sp, u32 > > +val, u32 reg) > > No for renaming - same reason as for previous patch. > I have tried to justify our rational behind this in previous patch, I hope that makes sense. > > Best regards, > Krzysztof
