Hello, thank you for the feedback regarding last patch. I have decided against using a copyright line despite the suggestion. CHANGELOG since PATCHv2: - dropped the Wiegand controller example from the dt-bindings doc, as the real one is in the bitbanged controller schema - fixed some indentation issues - removed controller class - functions with "__" as prefix are no longer exported - improved comment style - fixed the line length of the code to 100 columns - removed dev_warn calls for uinitialized controller attributes, instead the driver informs about the situation using dev_info and sets the uninitialized attribute to its default value - removed modalias from wiegand_device structure, as I have realized it is no longer needed - removed the list from wiegand_controller structure - used the tool "pahole" to optimally reorganize all the structures - ordered headers alphabetically - removed unnecessary casts - used attribute group instead of creating the files automatically Martin Zaťovič (4): dt-bindings: wiegand: add Wiegand controller common properties wiegand: add Wiegand bus driver dt-bindings: wiegand: add GPIO bitbanged Wiegand controller wiegand: add Wiegand GPIO bitbanged controller driver .../ABI/testing/sysfs-driver-wiegand-gpio | 9 + .../bindings/wiegand/wiegand-controller.yaml | 39 ++ .../bindings/wiegand/wiegand-gpio.yaml | 51 ++ MAINTAINERS | 14 + drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/wiegand/Kconfig | 28 + drivers/wiegand/Makefile | 2 + drivers/wiegand/wiegand-gpio.c | 316 +++++++++++ drivers/wiegand/wiegand.c | 500 ++++++++++++++++++ include/linux/wiegand.h | 155 ++++++ 11 files changed, 1117 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-driver-wiegand-gpio create mode 100644 Documentation/devicetree/bindings/wiegand/wiegand-controller.yaml create mode 100644 Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml create mode 100644 drivers/wiegand/Kconfig create mode 100644 drivers/wiegand/Makefile create mode 100644 drivers/wiegand/wiegand-gpio.c create mode 100644 drivers/wiegand/wiegand.c create mode 100644 include/linux/wiegand.h -- 2.39.2