Re: [PATCH v5 4/5] iio: temperature: tmp117: add TI TMP116 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marco,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v6.2]
[cannot apply to jic23-iio/togreg linus/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Marco-Felsch/dt-bindings-iio-ti-tmp117-fix-documentation-link/20230228-051305
patch link:    https://lore.kernel.org/r/20230227211230.165073-5-m.felsch%40pengutronix.de
patch subject: [PATCH v5 4/5] iio: temperature: tmp117: add TI TMP116 support
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20230228/202302280821.OXqGp2Tq-lkp@xxxxxxxxx/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/424113d7fdc257200d20da2991242a4050c04cb3
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Marco-Felsch/dt-bindings-iio-ti-tmp117-fix-documentation-link/20230228-051305
        git checkout 424113d7fdc257200d20da2991242a4050c04cb3
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/iio/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202302280821.OXqGp2Tq-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

>> drivers/iio/temperature/tmp117.c:111:2: error: expected '}' before ';' token
     111 | };
         |  ^
   drivers/iio/temperature/tmp117.c:106:55: note: to match this '{'
     106 | static const struct iio_chan_spec tmp117_channels[] = {
         |                                                       ^
   drivers/iio/temperature/tmp117.c:106:35: warning: 'tmp117_channels' defined but not used [-Wunused-const-variable=]
     106 | static const struct iio_chan_spec tmp117_channels[] = {
         |                                   ^~~~~~~~~~~~~~~
   drivers/iio/temperature/tmp117.c:85:12: warning: 'tmp117_write_raw' defined but not used [-Wunused-function]
      85 | static int tmp117_write_raw(struct iio_dev *indio_dev,
         |            ^~~~~~~~~~~~~~~~
   drivers/iio/temperature/tmp117.c:45:12: warning: 'tmp117_read_raw' defined but not used [-Wunused-function]
      45 | static int tmp117_read_raw(struct iio_dev *indio_dev,
         |            ^~~~~~~~~~~~~~~


vim +111 drivers/iio/temperature/tmp117.c

   105	
   106	static const struct iio_chan_spec tmp117_channels[] = {
   107		{
   108			.type = IIO_TEMP,
   109			.info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
   110				BIT(IIO_CHAN_INFO_CALIBBIAS) | BIT(IIO_CHAN_INFO_SCALE),
 > 111	};
   112	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux