On 2/27/23 21:00, Marco Felsch wrote:
On 23-02-27, Marek Vasut wrote:
On 2/27/23 20:01, Marco Felsch wrote:
Hi Marek,
On 23-02-27, Marek Vasut wrote:
Add #sound-dai-cells properties to SAI nodes.
Signed-off-by: Marek Vasut <marex@xxxxxxx>
---
Cc: Abel Vesa <abelvesa@xxxxxxxxxx>
Cc: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
Cc: Fabio Estevam <festevam@xxxxxxxxx>
Cc: Jacky Bai <ping.bai@xxxxxxx>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Cc: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>
Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
Cc: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
Cc: Michael Turquette <mturquette@xxxxxxxxxxxx>
Cc: NXP Linux Team <linux-imx@xxxxxxx>
Cc: Peng Fan <peng.fan@xxxxxxx>
Cc: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>
Cc: Richard Cochran <richardcochran@xxxxxxxxx>
Cc: Rob Herring <robh+dt@xxxxxxxxxx>
Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
Cc: Stephen Boyd <sboyd@xxxxxxxxxx>
Cc: devicetree@xxxxxxxxxxxxxxx
Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
Cc: linux-clk@xxxxxxxxxxxxxxx
---
arch/arm64/boot/dts/freescale/imx8mn.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index ed9ac6c5047c0..bbec860ef8548 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -294,6 +294,7 @@ spba2: spba-bus@30000000 {
ranges;
sai2: sai@30020000 {
+ #sound-dai-cells = <0>;
Please don't add it in front of the compatible and the reg property.
The #address-cells and #size-cells are also always on top, why should the
#sound-dai-cells be any different ? Where should they be ?
As of now my understanding of specifying a devicetree node was:
node-name@reg-nr {
compatible = "";
reg = <>;
// all pending properties below
...
};
@Rob, @Krzysztof:
Is this a (unwritten) rule/policy?
Marekt please ignore my comment if this is not the case.
Getting input from Rob/Krysztof is a good idea, thanks.
