Hi Marek,
thanks for the cleanup.
Am Donnerstag, 23. Februar 2023, 16:10:41 CET schrieb Marek Vasut:
> Document the LDB bridge subnode and add the subnode into the example.
> For the subnode to work, the block control must scan its subnodes and
> bind drivers to them, do not misuse either simple-bus or simple-mfd
> here.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Reviewed-by: Liu Ying <victor.liu@xxxxxxx>
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
> ---
> Cc: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> Cc: Fabio Estevam <festevam@xxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> Cc: NXP Linux Team <linux-imx@xxxxxxx>
> Cc: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx>
> Cc: Peng Fan <peng.fan@xxxxxxx>
> Cc: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>
> Cc: Richard Cochran <richardcochran@xxxxxxxxx>
> Cc: Richard Zhu <hongxing.zhu@xxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> ---
> V2: Add RB from Liu
> V3: - Update commit subject and drop space before fullstop.
> - Add RB from Krzysztof
> V4: No change
> ---
> .../soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> index a0f7c73510d04..f092916dc8594 100644
> ---
> a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> +++
> b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> @@ -23,6 +23,12 @@ properties:
> reg:
> maxItems: 1
>
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 1
> +
> '#power-domain-cells':
> const: 1
>
> @@ -78,9 +84,16 @@ properties:
> - const: isp1
> - const: dwe
>
> + bridge@5c:
> + type: object
> + $ref: /schemas/display/bridge/fsl,ldb.yaml#
> + unevaluatedProperties: false
> +
> required:
> - compatible
> - reg
> + - '#address-cells'
> + - '#size-cells'
> - '#power-domain-cells'
> - power-domains
> - power-domain-names
> @@ -114,5 +127,43 @@ examples:
> clock-names = "apb", "axi", "cam1", "cam2", "disp1", "disp2",
> "isp", "phy";
> #power-domain-cells = <1>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + bridge@5c {
> + compatible = "fsl,imx8mp-ldb";
> + clocks = <&clk IMX8MP_CLK_MEDIA_LDB>;
> + clock-names = "ldb";
> + reg = <0x5c 0x4>, <0x128 0x4>;
> + reg-names = "ldb", "lvds";
I remember that reg shall be stated right after compatible. Maybe this order
should be used this example as well.
Despite that:
Acked-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + ldb_from_lcdif2: endpoint {
> + remote-endpoint = <&lcdif2_to_ldb>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + ldb_lvds_ch0: endpoint {
> + remote-endpoint = <&ldb_to_lvdsx4panel>;
> + };
> + };
> +
> + port@2 {
> + reg = <2>;
> +
> + ldb_lvds_ch1: endpoint {
> + };
> + };
> + };
> + };
> };
> ...
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
