On Fri, Feb 24, 2023 at 10:43 AM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Thu, Feb 23, 2023 at 03:31:44PM -0600, Danny Kaehn wrote: > > This patchset allows USB-HID devices to have DeviceTree bindings through sharing > > the USB fwnode with the HID driver, and adds such a binding and driver > > implementation for the CP2112 USB to SMBus Bridge (which necessitated the > > USB-HID change). This change allows a CP2112 permanently attached in hardware to > > be described in DT and interoperate with other drivers. > > It's your responsibility to carry the tags you have got in the previous rounds > of the review. Please, be respectful to the reviewers who spent a lot of time > on yours, in particular, code. Otherwise why to bother with it (upstreaming) > at all? > > -- > With Best Regards, > Andy Shevchenko > > Hello Andy, My sincerest apologies on this! I wasn't actually aware that this is something I could do / am responsible for doing. No disrespect is intended, though I see how this would be frustrating for reviewers (I previously thought that maintainers used some sort of automated tool to keep track of who approved/acked what in previous versions, but didn't really know how that would work). If I'm understanding correctly, this means that whenever someone responds to my patch with a "Reviewed-by", etc.. I should be adding that tag to the end of the commit message of that patch if a future revision is needed? I assume this only applies on future revisions where patches other than the one initially reviewed are changed, and that any tags I take with should be dropped if that patch is changed? Apologies about these questions - - I looked for guidance on this in the various "submitting patches to the kernel" guides out there, and wasn't able to find much. Thanks, Danny Kaehn
