On Fri, Feb 24, 2023 at 03:25:30PM +0100, Andrew Jones wrote: > On Fri, Feb 24, 2023 at 02:00:44PM +0000, Ben Dooks wrote: > > On 21/02/2023 19:09, Andrew Jones wrote: ... > > > +/* void clear_page(void *page) */ > > > +ENTRY(__clear_page) > > > +WEAK(clear_page) > > > > out of interest, why the __clear_page() entry and the > > WEAK(clear_page)? > > I was inspired by memset, but, in hindsight, it doesn't make sense for > clear_page to be weak. Of course I failed to completely follow the memset pattern, which also has an export (in riscv_ksyms.c). I prefer the export in clear_page.S, though, as you've done. Thanks, drew
