Hi, On Fri, Feb 24, 2023, at 12:04, Sasha Finkelstein wrote: > On Fri, 24 Feb 2023 at 11:55, Mark Kettenis <mark.kettenis@xxxxxxxxx> wrote: > >> What is the motivation for including the firmware name in the device >> tree rather than constructing it in the driver like what is done for >> the broadcom wireless? > There is no way to identify the device subtype before the firmware is > uploaded, and so i need some way of figuring out which firmware to use. Some Broadcom bluetooth boards use the compatible of the root node (see btbcm_get_board_name in drivers/bluetooth/btbcm.c) which would be "apple,jXXX" for Apple Silicon. I believe the Broadcom WiFi driver has similar logic as well which marcan had to extend to instead of "brcm,board-type" because different WiFi boards can me matched to different Apple Silicon boards. I don't think that's the case for this touchscreen though. Sven
