On 23/02/2023 14:34, AngeloGioacchino Del Regno wrote: > In preparation for adding new bindings for new MediaTek SoCs, split out > the power-domain-names and power-domainsvariation from the `else` in > the current mediatek,mt8183-mali conditional. > > The sram-supply part is left in place to be disallowed for anything > that is not compatible with "mediatek,mt8183-mali" as this regulator > is MediaTek-specific and it is, and will ever be, used only for this > specific string due to the addition of the mediatek-regulator-coupler > driver. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > --- > .../devicetree/bindings/gpu/arm,mali-bifrost.yaml | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > index 02699d389be1..ac174c17e25f 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > @@ -145,6 +145,18 @@ allOf: > - power-domains > - resets > - reset-names > + - if: > + not: I think this makes the binding difficult to maintain. You have: 1. if - amlogic - then - some properties 2. if - renesas - then - some properties 3. if - not mediatek - then - something else 4. if - mediatek - then - some properties Instead just disallow power domains in each of other variants. Best regards, Krzysztof
