On Wed, 8 Feb 2023 08:23:12 -0800, Guenter Roeck wrote: > On Tue, Feb 07, 2023 at 03:23:14PM +0800, Hal Feng wrote: >> From: Emil Renner Berthing <kernel@xxxxxxxx> >> >> Register definitions and conversion constants based on sfctemp driver by >> Samin in the StarFive 5.10 kernel. > > "based on ..." does not belong here. Describe what the driver does, > not what it is based on. If you want to add a note about the origin > of the driver, add it in the comments on the top of the driver. Will reword the commit message in the next version. > > Please add the missing default: statements in the driver, OK. I will fix it accordingly. > and explain (for example in the comments at the top of the > driver) why you don't use continuous mode. The description > needs to be detailed and compelling enough that no one comes > back and implements a continuous mode version of the driver. As we discussed in [1], I will use continuous mode instead. Thanks. [1] https://lore.kernel.org/all/2c424d39-3a1d-3c91-d049-c0b941359bc3@xxxxxxxxxxxxxxxx/ Best regards, Hal
