On 23/02/2023 10:51, suijingfeng wrote: >>> diff --git a/Documentation/devicetree/bindings/display/loongson/loongson,display-controller.yaml b/Documentation/devicetree/bindings/display/loongson/loongson,display-controller.yaml >>> new file mode 100644 >>> index 000000000000..98b78f449a80 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/display/loongson/loongson,display-controller.yaml >> Filename based on compatible, so "loongson,ls2k1000-dc.yaml" > > what if we have more than one SoC, > > we have loongson,ls2k1000-dc, loongson,ls2k2000-dc and loongson,ls2k0500-dc > > we will have loongson,ls2k3000-dc in the future, then how should i write > this? Then it is fine. > > I want a single file yaml file include them all. > > I'm asking because we don't know which method is good, write three piece > of yaml or just one. > > Just tell me how to write this, i will follow you instruction. > >>> @@ -0,0 +1,58 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/display/loongson/loongson,display-controller.yaml# >>> >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Loongson Display Controller Device Tree Bindings >> Drop "Device Tree Bindings" > OK, >>> + >>> +maintainers: >>> + - Sui Jingfeng <suijingfeng@xxxxxxxxxxx> >>> + >>> +description: |+ >> Drop |+ >> >>> + >> No need for blank line. Do you see it anywhere else in the bindings? > OK, acceptable. >>> + The display controller is a PCI device, it has two display pipe. >>> + For the DC in LS2K1000 each way has a DVO output interface which >>> + provide RGB888 signals, vertical & horizontal synchronisations >>> + and the pixel clock. Each CRTC is able to support 1920x1080@60Hz, >>> + the maximum resolution is 2048x2048 according to the hardware spec. >>> + >>> +properties: >>> + $nodename: >>> + pattern: "^display-controller@[0-9a-f],[0-9a-f]$" >> Drop nodename. > > Are you sure about this? When i write this property, I'm reference the > ingenic,lcd.yaml . > > ingenic,lcd.yaml has nodename too. > > If I delete $nodename, then the test results say > '^display-controller@[0-9a-f],[0-9a-f]$' is not of type 'object'. > > log is pasted at below. I meant, drop entire nodename and pattern. Best regards, Krzysztof
