On 23/02/2023 10:08, Krzysztof Kozlowski wrote: > On 22/02/2023 12:50, Alexey Romanov wrote: >> Add basic support for the 32-bit Amlogic A1. This device tree > > Use subject prefixes matching the subsystem (which you can get for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching). > >> describes following compontents: CPU, GIC, IRQ, Timer, UART, >> PIN controller. It's capable of booting up into >> the serial console. >> >> This is based on arm64 version of meson-a1.dtsi. >> >> Signed-off-by: Alexey Romanov <avromanov@xxxxxxxxxxxxxx> >> --- >> arch/arm/boot/dts/meson-a1.dtsi | 151 ++++++++++++++++++++++++++++++++ > > There is such file and there is such DTS/hardware support. I don't see > any reason why entire DTSI should be duplicated. What's more, your > commit does not explain it - does not justify duplication. One more comment - I think you just added dead code. It's uncompilable/untestable. Otherwise, please share how to build this DTSI without DTS. Best regards, Krzysztof
