On 10:21-20230222, Ravi Gunasekaran wrote: [...] > >> + usbss0: cdns-usb@4104000 { > >> + compatible = "ti,j721e-usb"; > >> + reg = <0x00 0x04104000 0x00 0x100>; > >> + clocks = <&k3_clks 360 16>, <&k3_clks 360 15>; > >> + clock-names = "ref", "lpm"; > >> + assigned-clocks = <&k3_clks 360 16>; /* USB2_REFCLK */ > >> + assigned-clock-parents = <&k3_clks 360 17>; > >> + power-domains = <&k3_pds 360 TI_SCI_PD_EXCLUSIVE>; > >> + #address-cells = <2>; > >> + #size-cells = <2>; > >> + ranges; > >> + dma-coherent; > >> + > >> + status = "disabled"; > > > > Why disabled by default? > > One of the comment received in the v9 series was to disable the node in > the include file and then enable it in the board specific DTS file. > Changes in this series addressed that comment. Document in the node why it is disabled by default. Also do make sure All K3 SoCs dtsi nodes follow the same argument. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D