Re: [PATCH v3 2/3] dt-bindings: net: bluetooth: Add NXP bluetooth support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof,

Thank you for reviewing this patch. I have fixed all the review comments in this document.
Please let me know if you have any more comments or suggestions on the new v4 patch.

> >  .../bindings/net/bluetooth/nxp,w8xxx-bt.yaml  | 44
> > +++++++++++++++++++
> 
> I don't think I proposed such filename.
Renamed file to nxp,w8987-bt.yaml


> > +examples:
> > +  - |
> > +    uart2 {
> 
> This is a friendly reminder during the review process.
> 
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all requested
> changes or keep discussing them.
> 
> Thank you.
> 
> > +        uart-has-rtscts;
> > +        bluetooth {
> > +          compatible = "nxp,iw416-bt";
> 
> Wrong indentation. Use 4 spaces for example indentation.
> 
Updated example indentation to use 4 spaces.

Thanks,
Neeraj




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux