Hi Clément, On Thu, Feb 9, 2023 at 4:14 PM Clément Léger <clement.leger@xxxxxxxxxxx> wrote: > Add support for Renesas RZ/N1 GMAC. This support uses a custom PCS (MIIC) > which is handle by parsing the pcs-handle device tree property. > > Signed-off-by: Clément Léger <clement.leger@xxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rzn1.c > +static int rzn1_dwmac_remove(struct platform_device *pdev) > +{ > + struct rzn1_dwmac *dwmac = get_stmmac_bsp_priv(&pdev->dev); > + int ret = stmmac_dvr_remove(&pdev->dev); This needs an update for commit ff0011cf56014b4d ("net: stmmac: Make stmmac_dvr_remove() return void") in net-next/master. > + > + if (dwmac->pcs) > + miic_destroy(dwmac->pcs); > + > + return ret; > +} Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds