Hi Rob, On Mon, Feb 20, 2023 at 11:15:53AM -0600, Rob Herring wrote: > > On Mon, 20 Feb 2023 16:41:16 +0000, Daniel Golle wrote: > > Convert mediatek,sgmiiisys bindings to DT schema format. > > Add maintainer Matthias Brugger, no maintainers were listed in the > > original documentation. > > As this node is also referenced by the Ethernet controller and used > > as SGMII PCS add this fact to the description. > > Move the file to Documentation/devicetree/bindings/pcs/ which seems more > > appropriate given that the great majority of registers are related to > > SGMII PCS functionality and only one register represents clock bits. > > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx> > > --- > > .../arm/mediatek/mediatek,sgmiisys.txt | 25 ---------- > > .../bindings/net/pcs/mediatek,sgmiisys.yaml | 49 +++++++++++++++++++ > > 2 files changed, 49 insertions(+), 25 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt > > create mode 100644 Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > ./Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.yaml: $id: relative path/filename doesn't match actual path or filename > expected: http://devicetree.org/schemas/net/pcs/mediatek,sgmiisys.yaml# I simply didn't even consider that moving the file to its correct location may cause this kind of havoc. Please apologize, I'm quite new to this whole dt-schema game and still learning... > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/03f9d40849dd2d563a93b27732a7b5d7dd1defc5.1676910958.git.daniel@xxxxxxxxxxxxxx > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > I've fixed the wrong path now also within mediatek,sgmiisys.yaml itself. Result: [daniel@box linux.git]$ make dt_binding_check DT_SCHEMA_FILES=mediatek,sgmiisys HOSTCC scripts/dtc/util.o LEX scripts/dtc/dtc-lexer.lex.c YACC scripts/dtc/dtc-parser.tab.[ch] HOSTCC scripts/dtc/dtc-lexer.lex.o HOSTCC scripts/dtc/dtc-parser.tab.o HOSTCC scripts/dtc/checks.o HOSTLD scripts/dtc/dtc HOSTCC scripts/dtc/libfdt/fdt.o HOSTCC scripts/dtc/libfdt/fdt_ro.o HOSTCC scripts/dtc/libfdt/fdt_wip.o HOSTCC scripts/dtc/libfdt/fdt_sw.o HOSTCC scripts/dtc/libfdt/fdt_rw.o HOSTCC scripts/dtc/libfdt/fdt_strerror.o HOSTCC scripts/dtc/libfdt/fdt_empty_tree.o HOSTCC scripts/dtc/libfdt/fdt_addresses.o HOSTCC scripts/dtc/libfdt/fdt_overlay.o HOSTCC scripts/dtc/fdtoverlay.o HOSTLD scripts/dtc/fdtoverlay LINT Documentation/devicetree/bindings CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json DTEX Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.example.dts DTC_CHK Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.example.dtb I'll wait for more potentials comments on the series and re-submit tomorrow. Thank you! Daniel
