On 18.02.2023 13:24, Frank Wunderlich wrote:
Hi, finally get some time to bootup with this series on my r2. I see that inserting the port@5 as cpu-port maps this as default-cpu because dsa-core uses first found cpu-port as default (dsa_tree_setup_cpu_ports in dsa.c) and because of lower bandwidth (rgmii instead of trgmii) not the best choice. But it look worse...network is currently broken (set both gmacs up). I see arp-packets reaching remote side, but reponse is not received by r2 I have tested it on 6.2-rc8 (wan-port), maybe additional patches are needed?...userspace setup should be right. so i added series on top of net-next (no additional patches except some basic like build-script,defconfig and such)...same result... i'm not sure if i change the mapping from userspace back to eth0, so disabled port@5 in switch, now port6 is cpu-port again and it works...so something is wrong with port5 of switch or gmac1.
That's a driver issue and will be fixed once an accepted version of these patches [0] [1] [2] are applied to net-next. You should have them on your inbox, I specifically told Richard to CC you.
This is devicetree bindings. We're here to describe the hardware. The way a driver works should not affect describing the hardware.
To address the lower bandwidth situation you mentioned, a devicetree property to designate a CPU port as the default CPU port could be introduced. I'm not aware of a similar conversation so I'll send a mail to netdev to discuss this. Will CC you.
[0] https://lore.kernel.org/netdev/20230212213949.672443-1-richard@xxxxxxxxxxxxxxx/ [1] https://lore.kernel.org/netdev/20230212214027.672501-1-richard@xxxxxxxxxxxxxxx/ [2] https://lore.kernel.org/netdev/20230212215152.673221-1-richard@xxxxxxxxxxxxxxx/
Arınç
