On 16/02/2023 06:33, Yong Wu wrote: > From: "Chengci.Xu" <chengci.xu@xxxxxxxxxxxx> > > Add descriptions for mt8188 IOMMU which also use ARM Short-Descriptor > translation table format. > > In mt8188, there are two smi-common HW and IOMMU, one is for vdo(video > output), the other is for vpp(video processing pipe). They connects > with different smi-larbs, then some setting(larbid_remap) is different. > Differentiate them with the compatible string. > > Something like this: > > IOMMU(VDO) IOMMU(VPP) > | | > SMI_COMMON_VDO SMI_COMMON_VPP > > --------------- ---------------- > | | ... | | ... > larb0 larb2 ... larb1 larb3 ... > > We also have an IOMMU that is for infra master like PCIe. > And infra master don't have the larb and ports. > > Signed-off-by: Chengci.Xu <chengci.xu@xxxxxxxxxxxx> > Reviewed-by: Yong Wu <yong.wu@xxxxxxxxxxxx> > --- > Hi Krzysztof, > I added some comment about larbid index, this is for readable when > adding iova_region_larb_msk in the code. > I'm not sure if it is ok for you, thus don't keep your A-b currently. > Thanks. > --- > .../bindings/iommu/mediatek,iommu.yaml | 12 +- > .../memory/mediatek,mt8188-memory-port.h | 489 ++++++++++++++++++ > 2 files changed, 500 insertions(+), 1 deletion(-) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
