On 16/02/2023 23:25, Ryan.Wanner@xxxxxxxxxxxxx wrote: > From: Ryan Wanner <Ryan.Wanner@xxxxxxxxxxxxx> > > Adding macros for sama7g drive strength. Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). Nothing improved here. > > Signed-off-by: Ryan Wanner <Ryan.Wanner@xxxxxxxxxxxxx> > --- > changes from v1: > - Fix ABI break. > - Add some small comments to describe drive strength macros. > > include/dt-bindings/pinctrl/at91.h | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/include/dt-bindings/pinctrl/at91.h b/include/dt-bindings/pinctrl/at91.h > index e8e117306b1b..12f3edf2a9c4 100644 > --- a/include/dt-bindings/pinctrl/at91.h > +++ b/include/dt-bindings/pinctrl/at91.h > @@ -42,8 +42,16 @@ > #define AT91_PERIPH_C 3 > #define AT91_PERIPH_D 4 > > -#define ATMEL_PIO_DRVSTR_LO 1 > +/*These macros are for all other at91 pinctrl drivers*/ > +#define ATMEL_PIO_DRVSTR_LO 0 > +#define ATMEL_PIO_DRVSTR_LO_1 1 > #define ATMEL_PIO_DRVSTR_ME 2 > #define ATMEL_PIO_DRVSTR_HI 3 > > +/* These macros are for the sama7g5 pinctrl driver*/ What I mean, is the explanation of the constants. What is LO_D? > +#define ATMEL_PIO_DRVSTR_LO_D 0 Also looks like wrong indentation between define and value. > +#define ATMEL_PIO_DRVSTR_HI_A 1 > +#define ATMEL_PIO_DRVSTR_LO_C 2 > +#define ATMEL_PIO_DRVSTR_LO_B 3 > + > #endif /* __DT_BINDINGS_AT91_PINCTRL_H__ */ Best regards, Krzysztof
