On 16.02.2023 13:52, Neil Armstrong wrote:
> On 16/02/2023 12:49, Heiner Kallweit wrote:
>> Reflect in the binding that the cd interrupt is optional,
>> and add a description of the interrupts.
>>
>> Fixes: 09b31a610328 ("dt-bindings: mmc: meson-gx: support specifying cd interrupt")
>> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
>> ---
>> .../devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>> index c8c30300d..cd3f75821 100644
>> --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>> @@ -28,7 +28,11 @@ properties:
>> maxItems: 1
>> interrupts:
>> + minItems: 1
>> maxItems: 2
>> + description:
>> + mmc controller instance interrupt
>> + optional card detect interrupt
>
> I would instead write:
>
> interrupts:
> minItems: 1
> items:
> - description: mmc controller instance
> - description: card detect
>
> and drop maxItems.
>
Thanks for the hint! Bindings isn't really my area of expertise (yet).
> Neil
>> clocks:
>> maxItems: 3
>
