Hi Andrew, > Am 16.02.2023 um 17:19 schrieb Andrew Davis <afd@xxxxxx>: > > On 2/16/23 10:08 AM, H. Nikolaus Schaller wrote: >> Hi, >>> Am 16.02.2023 um 16:33 schrieb Andrew Davis <afd@xxxxxx>: >>> >>> Signed-off-by: Andrew Davis <afd@xxxxxx> >>> --- >>> .../devicetree/bindings/arm/omap/omap.yaml | 174 ++++++++++++++++++ >>> 1 file changed, 174 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/arm/omap/omap.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/arm/omap/omap.yaml b/Documentation/devicetree/bindings/arm/omap/omap.yaml >>> new file mode 100644 >>> index 0000000000000..cf07a7a7df279 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/arm/omap/omap.yaml >>> @@ -0,0 +1,174 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/arm/omap/omap.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Texas Instruments OMAP SoC architecture device tree bindings >>> + >>> +maintainers: >>> + - Tony Lindgren <tony@xxxxxxxxxxx> >>> + >>> +description: | >>> + Platforms based on Texas Instruments OMAP SoC architecture. >>> + >>> +properties: >>> + $nodename: >>> + const: '/' >>> + compatible: >>> + oneOf: >>> + >>> + - description: TI OMAP2420 SoC based platforms >>> + items: >>> + - enum: >>> + - ti,omap2420-h4 # TI OMAP2420 H4 board >>> + - nokia,n800 # Nokia N800 >>> + - nokia,n810 # Nokia N810 >>> + - nokia,n810-wimax # Nokia N810 WiMax >>> + - const: ti,omap2420 >>> + - const: ti,omap2 >>> + >>> + - description: TI OMAP2430 SoC based platforms >>> + items: >>> + - enum: >>> + - ti,omap2430-sdp # TI OMAP2430 SDP >>> + - const: ti,omap2430 >>> + - const: ti,omap2 >>> + >>> + - description: TI OMAP3430 SoC based platforms >>> + items: >>> + - enum: >>> + - logicpd,dm3730-som-lv-devkit # LogicPD Zoom OMAP35xx SOM-LV Development Kit >>> + - logicpd,dm3730-torpedo-devkit # LogicPD Zoom OMAP35xx Torpedo Development Kit >>> + - ti,omap3430-sdp # TI OMAP3430 SDP >>> + - ti,omap3-beagle # TI OMAP3 BeagleBoard >>> + - compulab,omap3-cm-t3530 # CompuLab CM-T3530 >>> + - timll,omap3-devkit8000 # TimLL OMAP3 Devkit8000 >>> + - ti,omap3-evm # TI OMAP35XX EVM (TMDSEVM3530) >>> + - ti,omap3-ldp # TI OMAP3430 LDP (Zoom1 Labrador) >>> + - nokia,omap3-n900 # Nokia N900 >>> + - const: ti,omap3430 >>> + - const: ti,omap3 >>> + >>> + - description: TI OMAP3630 SoC based platforms >>> + items: >>> + - enum: >>> + - logicpd,dm3730-som-lv-devkit # LogicPD Zoom DM3730 SOM-LV Development Kit >>> + - logicpd,dm3730-torpedo-devkit # LogicPD Zoom DM3730 Torpedo + Wireless Development Kit >>> + - ti,omap3-beagle-xm # TI OMAP3 BeagleBoard xM >>> + - compulab,omap3-cm-t3730 # CompuLab CM-T3730 >>> + - amazon,omap3-echo # Amazon Echo (first generation) >>> + - ti,omap3-evm-37xx # TI OMAP37XX EVM (TMDSEVM3730) >>> + - ti,omap3-gta04 # OMAP3 GTA04 >> precisely the GTA04 was not a TI product, but from Golden Delicious Computers. >> It got this compatible because it originally shared a lot of device tree with the ti,omap3-beagle-xm. >> Well, we could add a vendor prefix ("goldelico") and update the device trees to "goldelico,gta04". >> Generally, there is also the OpenPandora with both OMAP3 variants (3430 and 3630): >> compatible = "openpandora,omap3-pandora-600mhz", "ti,omap3430", "ti,omap3"; >> compatible = "openpandora,omap3-pandora-1ghz", "ti,omap3630", "ti,omap36xx", "ti,omap3"; >> But it is also missing a vendor prefix. Should I send a patch for both topics? >> Before the scheme is merged or afterwards? > > I'd suggest we get as many fixes into the actual DT files before the schemas > are solidified. Doing it after would mean changes in two places vs one. Ok, I'll prepare and send a patch set asap. BR and thanks, Nikolaus
