On Thu, 16 Feb 2023 11:32:31 +0100, Emil Renner Berthing wrote: > On Thu, 16 Feb 2023 at 11:09, Conor Dooley <conor.dooley@xxxxxxxxxxxxx> wrote: >> >> On Thu, Feb 16, 2023 at 09:50:37AM +0000, Conor Dooley wrote: >> > On Thu, Feb 16, 2023 at 10:27:17AM +0100, Emil Renner Berthing wrote: >> > > On Wed, 15 Feb 2023 at 15:04, Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> wrote: >> > > > On 2/14/2023 5:53 PM, Emil Renner Berthing wrote: >> > > > > On Tue, 20 Dec 2022 at 02:12, Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> wrote: >> > >> > > > >> + model = "StarFive VisionFive 2 VB"; >> > > > >> + compatible = "starfive,visionfive-2-vb", "starfive,jh7110"; >> > > > > >> > > > > Hi Hal, >> > > > > >> > > > > I just want to double check, is "VisionFive 2 VA" / "visoinfive-2-va" >> > > > > and "VisionFive 2 VB" / "visionfive-2-vb" really what you want? I >> > > > > still think having these names match what is printed on the silkscreen >> > > > > makes it a lot easier for everybody. Even your own releases calls the >> > > > > boards "v1.2A" and "v1.3B": >> > > > > https://github.com/starfive-tech/VisionFive2/releases/ >> > > > > >> > > > > So I'd suggest >> > > > > model = "StarFive VisionFive 2 v1.3B"; >> > > > > compatible = "starfive,visionfive-2-v1.3b", "starfive,jh7110"; >> > > > > >> > > > > I haven't seen these "VA" and "VB" anywhere else, so if you don't want >> > > > > the version numbers and can promise that there will be no incompatible >> > > > > future revisions of the boards then maybe just drop the "V". Eg. >> > > > > model = "StarFive VisionFive 2 B"; >> > > > > compatible = "starfive,visionfive-2-b", "starfive,jh7110"; >> > > > >> > > > The version A board has reached the end of life. As far as I know, the >> > > > version B board will not update also unless there are some important >> > > > requirements and StarFive decides to update. Furthermore, it's too late >> > > > to change the compatible as patch 1 was already accepted. Will it be >> > > > easier to read if I modify it as below? >> > > > >> > > > model = "StarFive VisionFive 2 vB"; >> > > > compatible = "starfive,visionfive-2-vb", "starfive,jh7110"; >> > > >> > > Oh, that's sad that the kernel will now end up calling the boards >> > > something that's used nowhere else, even by StarFive :/ >> > > But yeah, I guess vA and vB are a little easier to read. >> > >> > Nothing has been released with that name so AFAIU we can change it >> > still. If you sort it out today/tomorrow I'll try get it to Arnd before >> > the merge window opens... >> > >> > I might've jumped the gun a bit here, I thought that it'd been changed >> > to what you (Emil) had suggested. > > No, I'm sorry for being late here. The below definitely looks better to me. > > Hal, would you be fine with this change? I'm fine with this. It will be more exact. Thanks. Best regards, Hal > >> >> -- >8 -- >> From 4d44e8a83716d1caa314f25a95bd21ac8904909e Mon Sep 17 00:00:00 2001 >> From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> >> Date: Thu, 16 Feb 2023 09:58:22 +0000 >> Subject: [PATCH] dt-bindings: riscv: correct starfive visionfive 2 compatibles >> >> Using "va" and "vb" doesn't match what's written on the board, or the >> communications from StarFive. >> Switching to using the silkscreened version number will ease confusion & >> the risk of another spin of the board containing a "conflicting" version >> identifier. >> >> Suggested-by: Emil Renner Berthing <emil.renner.berthing@xxxxxxxxxxxxx> >> Fixes: 97b7ed072784 ("dt-bindings: riscv: Add StarFive JH7110 SoC and VisionFive 2 board") >> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/riscv/starfive.yaml | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml >> index 60c7c03fcdce..cc4d92f0a1bf 100644 >> --- a/Documentation/devicetree/bindings/riscv/starfive.yaml >> +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml >> @@ -26,8 +26,8 @@ properties: >> >> - items: >> - enum: >> - - starfive,visionfive-2-va >> - - starfive,visionfive-2-vb >> + - starfive,visionfive-2-v1.2a >> + - starfive,visionfive-2-v1.3b >> - const: starfive,jh7110 >> >> additionalProperties: true >> -- >> 2.39.0 >> >>
