On 14/02/2023 13:13, Shradha Todi wrote:
> Use samsung instead of exynos for all common functions
> like probe/remove/suspend/resume.
>
> Suggested-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx>
> Signed-off-by: Shradha Todi <shradha.t@xxxxxxxxxxx>
> ---
> drivers/pci/controller/dwc/pci-samsung.c | 42 ++++++++++++------------
> 1 file changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-samsung.c b/drivers/pci/controller/dwc/pci-samsung.c
> index 719d284e1552..dc8ec0b546fd 100644
> --- a/drivers/pci/controller/dwc/pci-samsung.c
> +++ b/drivers/pci/controller/dwc/pci-samsung.c
> @@ -60,7 +60,7 @@ struct samsung_pcie {
> struct regulator_bulk_data supplies[2];
> };
>
> -static int exynos_pcie_init_clk_resources(struct samsung_pcie *sp)
> +static int samsung_pcie_init_clk_resources(struct samsung_pcie *sp)
Same as before - I don't see here benefit.
> {
> struct device *dev = sp->pci.dev;
> int ret;
> @@ -74,7 +74,7 @@ static int exynos_pcie_init_clk_resources(struct samsung_pcie *sp)
> return clk_bulk_prepare_enable(sp->clk_cnt, sp->clks);
> }
>
(...)
>
> -static struct platform_driver exynos_pcie_driver = {
> - .probe = exynos_pcie_probe,
> - .remove = __exit_p(exynos_pcie_remove),
> +static struct platform_driver samsung_pcie_driver = {
> + .probe = samsung_pcie_probe,
> + .remove = __exit_p(samsung_pcie_remove),
> .driver = {
> - .name = "exynos-pcie",
> - .of_match_table = exynos_pcie_of_match,
> - .pm = &exynos_pcie_pm_ops,
> + .name = "samsung-pcie",
This "name" has some point... but I think it would break now all module
users.
> + .of_match_table = samsung_pcie_of_match,
> + .pm = &samsung_pcie_pm_ops,
> },
> };
> -module_platform_driver(exynos_pcie_driver);
> +module_platform_driver(samsung_pcie_driver);
> MODULE_LICENSE("GPL v2");
> -MODULE_DEVICE_TABLE(of, exynos_pcie_of_match);
> +MODULE_DEVICE_TABLE(of, samsung_pcie_of_match);
Best regards,
Krzysztof
