Hej Mark,
On 2023-02-15 03:52:34 +0900, Kazuki wrote:
> On Fri, Jan 13, 2023 at 03:57:26PM +0000, Mark Brown wrote:
> > On Fri, 13 Jan 2023 19:23:07 +0900, Hector Martin wrote:
> > > Commits f6c911f3308c ("spi: dt-bindings: Introduce
> > > spi-cs-setup-ns property") and 33a2fde5f77b ("spi: Introduce
> > > spi-cs-setup-ns property") introduced a new property to represent the
> > > CS setup delay in the device tree, but they have some issues:
> > >
> > > - The property is only parsed as a 16-bit integer number of nanoseconds,
> > > which limits the maximum value to ~65us. This is not a reasonable
> > > upper limit, as some devices might need a lot more.
> > > - The property name is inconsistent with other delay properties, which
> > > use a "*-delay-ns" naming scheme.
> > > - Only the setup delay is introduced, but not the related hold and
> > > inactive delay times.
> > >
> > > [...]
> >
> > Applied to
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
> >
> > Thanks!
> >
> > [1/3] spi: Use a 32-bit DT property for spi-cs-setup-delay-ns
> > commit: f276aacf5d2f7fb57e400db44c807ea3b9525fd6
>
> Shouldn't this be sent to 6.2 before the property becomes a stable ABI?
can we still get "spi: Use a 32-bit DT property for
spi-cs-setup-delay-ns" into 6.2?
If not I can send a single line patch which switches
of_property_read_u16() to of_property_read_u32() to avoid defining
"spi-cs-setup-delay-ns" to u16 as stable devicetree ABI.
sorry this comes so late before 6.2, we missed to track the patches.
Thanks,
Janne
