On 15/02/2023 09:18, Javier Carrasco wrote: > These Real Time Clocks are managed by the rtc-pcf85363 device driver, > which now supports the quartz-load-femtofarads property. > > Signed-off-by: Javier Carrasco <javier.carrasco@xxxxxxxxxxxxxx> > --- > v2: > - create new bindings instead of adding conditional properties to an > existing one. > > .../devicetree/bindings/rtc/nxp,pcf85363.yaml | 60 +++++++++++++++++++ > .../devicetree/bindings/rtc/nxp,pcf8563.yaml | 2 - > 2 files changed, 60 insertions(+), 2 deletions(-) > create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf85363.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85363.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf85363.yaml > new file mode 100644 > index 000000000000..52aa3e2091e9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85363.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/nxp,pcf85363.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Philips PCF85263/PCF85363 Real Time Clock > + > +maintainers: > + - Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > + > +allOf: > + - $ref: rtc.yaml# > + > +properties: > + compatible: > + enum: > + - nxp,pcf85263 > + - nxp,pcf85363 > + > + reg: > + maxItems: 1 > + > + "#clock-cells": > + const: 0 > + > + clock-output-names: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + quartz-load-femtofarads: > + description: > + The capacitive load of the quartz(x-tal). > + enum: [6000, 7000, 12500] > + default: 7000 > + > + start-year: true > + wakeup-source: true You could drop these two and use "unevaluatedProperties: false" instead of additionalProp - less coding and binding already will be prepared for any new RTC common properties. But it is fine for me as is. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
