On Wed, Feb 15, 2023 at 06:16:35PM +0800, William Qiu wrote: > > > On 2023/2/15 18:00, Emil Renner Berthing wrote: > > On Tue, 14 Feb 2023 at 13:21, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > >> > >> On Fri, 3 Feb 2023 at 09:19, William Qiu <william.qiu@xxxxxxxxxxxxxxxx> wrote: > >> > > >> > Hi, > >> > > >> > This patchset adds initial rudimentary support for the StarFive > >> > designware mobile storage host controller driver. And this driver will > >> > be used in StarFive's VisionFive 2 board. The main purpose of adding > >> > this driver is to accommodate the ultra-high speed mode of eMMC. > >> > > >> > The last patch should be applied after the patchset [1]: > >> > [1] https://lore.kernel.org/all/20221220011247.35560-1-hal.feng@xxxxxxxxxxxxxxxx/ > >> > > >> > Changes since v2: > >> > - Wraped commit message according to Linux coding style. > >> > - Rephrased the description of the patches. > >> > - Changed the description of syscon regsiter. > >> > - Dropped redundant properties. > >> > > >> > The patch series is based on v6.1. > >> > > >> > William Qiu (3): > >> > dt-bindings: mmc: Add StarFive MMC module > >> > mmc: starfive: Add sdio/emmc driver support > >> > riscv: dts: starfive: Add mmc node > >> > > >> > .../bindings/mmc/starfive,jh7110-mmc.yaml | 77 ++++++++ > >> > MAINTAINERS | 6 + > >> > .../jh7110-starfive-visionfive-2.dtsi | 23 +++ > >> > arch/riscv/boot/dts/starfive/jh7110.dtsi | 37 ++++ > >> > drivers/mmc/host/Kconfig | 10 + > >> > drivers/mmc/host/Makefile | 1 + > >> > drivers/mmc/host/dw_mmc-starfive.c | 185 ++++++++++++++++++ > >> > 7 files changed, 339 insertions(+) > >> > create mode 100644 Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml > >> > create mode 100644 drivers/mmc/host/dw_mmc-starfive.c > >> > > >> > >> Patch 1 and patch 2 applied for next, thanks! > >> > >> Note that I fixed some checkpatch errors/warnings. Next time, please > >> run ./scripts/checkpatch.pl before you submit your patches. > > > > Hi, > > > > Something here is not right. The bindings document "starfive,sysreg", > > but the code is looking for "starfive,syscon". > > William, did you test this and run dtbs_check before sending this series? > > > > /Emil > > Hi Emil, > > Sorry about that, it's my negligence that I did dtbs_check without dtbs_check would be okay though, no? The binding and dts (from checking with eyeballs!) are consistent & it is just the driver that is looking for the wrong property name, no? > checking the configuration of CONFIG_SOC_STARFIVE. I made a modification > in the next version and add binding for all the syscon at the same time. Next > time I'll make sure the check is correct.I'm sorry again for this oversight. > I'll send v4 patch series today. Ulf's subsystem & his rules, but I would just send a follow-on patch fixing the driver to use the property that is in the dt-binding. Sorta unrelated, but please remind me about the dts patch once the base dts is merged. It's still in the RISC-V patchwork so *should* be fine, but in case the base dts takes a while it may get automatically archived. Thanks, Conor.
Attachment:
signature.asc
Description: PGP signature
