On 2/14/2023 1:47 AM, Krzysztof Kozlowski wrote: > On 13/02/2023 20:01, Melody Olvera wrote: >> Add nodes for IPCC, MPSS, and AOSS drivers. Also update >> the scm node to include its interconnect. >> >> Signed-off-by: Melody Olvera <quic_molvera@xxxxxxxxxxx> >> --- > >> >> + aoss_qmp: power-controller@c300000 { >> + compatible = "qcom,qdu1000-aoss-qmp", "qcom,aoss-qmp"; >> + reg = <0x0 0xc300000 0x0 0x400>; >> + interrupts-extended = <&ipcc IPCC_CLIENT_AOP >> + IPCC_MPROC_SIGNAL_GLINK_QMP >> + IRQ_TYPE_EDGE_RISING>; >> + mboxes = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP>; >> + >> + #clock-cells = <0>; >> + #power-domain-cells = <1>; > This does not look right. Which part of aoss-qmp registers power domains? You're right; I didn't realize part of the driver that registered this had been removed. Will drop that line. Thanks, Melody > > Best regards, > Krzysztof >