Hi, I'm waiting for that other series that this depends on, but in the meantime, there is one thing that has been bugging me... On Fri, Feb 10, 2023 at 04:02:04PM +0100, Neil Armstrong wrote: > diff --git a/drivers/usb/typec/ucsi/ucsi_glink.c b/drivers/usb/typec/ucsi/ucsi_glink.c > new file mode 100644 > index 000000000000..9123f8a571e7 > --- /dev/null > +++ b/drivers/usb/typec/ucsi/ucsi_glink.c > @@ -0,0 +1,320 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2019-2020, The Linux Foundation. All rights reserved. > + * Copyright (c) 2022-2023, Linaro Ltd > + */ Is that correct? Shouldn't it just be: Copyright (c) 2023, Linaro Ltd and that's it? Otherwise this look OK to me. thanks, -- heikki