On Tue, 2023-02-14 at 10:36 +0100, AngeloGioacchino Del Regno wrote: > Il 14/02/23 04:11, Yong Wu ha scritto: > > Add iova_region_larb_msk for mt8195. We separate the 16GB iova > > regions > > by each device's larbid/portid. > > Refer to include/dt-bindings/memory/mt8195-memory-port.h > > > > Define a new macro MT8192_MULTI_REGION_MAX_NR to indicate > > the index of mt8xxx_larb_region_msk and > > "struct mtk_iommu_iova_region mt8192_multi_dom" > > are the same. > > > > Signed-off-by: Yong Wu <yong.wu@xxxxxxxxxxxx> > > Sorry but... you *are* introducing a iova_region_larb_msk for MT8192 > later, > while you're introducing definitions containing the `MT8192` name in > a commit > that introduces the same but for MT8195. > > I strongly suggest to, at this point, introduce MT8192 region mask > here, along > with the MT8192 definitions, and MT8195 after that :-) Make sense. Thanks very much. Will fix it. > > > Regards, > Angelo > >
