Re: [PATCH] arm64: dts: qcom: msm8996: Add missing property for OnePlus 3T

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 13.02.2023 21:16, Guilherme G. Piccoli wrote:
> Commit 5a134c940cd3 ("arm64: dts: qcom: msm8996: add support for oneplus3(t)")
> added support for OnePlus 3T device, but missed the "qcom,msm-id"
> property - without that, skales-dtbtool fails to build the device tree
> image. Let's hereby add it, mimic'ing OnePlus 3.
> 
> Fixes: 5a134c940cd3 ("arm64: dts: qcom: msm8996: add support for oneplus3(t)")
> Cc: Harry Austen <hpausten@xxxxxxxxxxxxxx>
> Cc: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@xxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts b/arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts
> index 34f837dd0c12..5dc8f0adab30 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts
> @@ -14,6 +14,7 @@ / {
>  	qcom,board-id = <8 0 15811 26>,
>  			<8 0 15811 27>,
>  			<8 0 15811 28>;
> +	qcom,msm-id = <246 0x30001>;
Hm, this doesn't sound right.. Internet says 3T has 8996Pro..
Could you check:

/sys/bus/soc/devices/soc0/soc_id  # reg[0]
/sys/bus/soc/devices/soc0/revision # reg[1] after some shifting

Also, please include include/dt-bindings/arm/qcom,ids.h and use
the preprocessor constant from there instead of a magic number in
the first part of the reg value.

Konrad
>  };
>  
>  &adsp_pil {



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux