On 13/02/2023 16:08, Janne Grunau wrote: > On 2023-02-13 15:36:33 +0100, Krzysztof Kozlowski wrote: >> On 13/02/2023 15:01, Janne Grunau wrote: >>>>> + >>>>> + pmgr: power-management@23b700000 { >>>>> + compatible = "apple,t8112-pmgr", "apple,pmgr", "syscon", "simple-mfd"; >>>> >>>> Why this is simple-mfd? >>> >>> I suppose because the syscon device is not limited to power domain >>> controls. The dt-bindings in arm/apple/apple,pmgr.yaml specify those >>> compatibles. See the original discussion in: >>> >>> https://lore.kernel.org/linux-devicetree/57991dac-196e-a76d-831a-d4ac166bfe29@xxxxxxxxx/ >> >> This did not answer my concerns. There are no children here. > > The child nodes are in t8112-pmgr.dtsi Ahhh, so this is overridden? Then it's fine. Best regards, Krzysztof