Re: [PATCH 1/9] ARM: dts: imx28-apf28: Convert to use label references

[Stefan Wahren <stefan.wahren@xxxxxxxx>]

Hi Sébastien,

Am 13.02.23 um 09:22 schrieb Sébastien Szymanski:
> Hello Stefan,
>
> On 2/1/23 21:33, Stefan Wahren wrote:
> > These Armadeus board files still use node name and unit address
> > to reference parts from the imx28.dtsi . This causes a lot of
> > redundancy. So use label references in order to make it easier
> > to maintain.
> >
> > Signed-off-by: Stefan Wahren <stefan.wahren@xxxxxxxx>
> > Cc: <support@xxxxxxxxxxxx>
> > ---
> >   arch/arm/boot/dts/imx28-apf28.dts    |  96 ++++-----
> >   arch/arm/boot/dts/imx28-apf28dev.dts | 312 +++++++++++++--------------
> >   2 files changed, 196 insertions(+), 212 deletions(-)
...
> > diff --git a/arch/arm/boot/dts/imx28-apf28dev.dts 
> > b/arch/arm/boot/dts/imx28-apf28dev.dts
> > index 1b253b47006c..47e2397193ad 100644
> > --- a/arch/arm/boot/dts/imx28-apf28dev.dts
> > +++ b/arch/arm/boot/dts/imx28-apf28dev.dts
> > @@ -10,166 +10,6 @@ / {
> >       model = "Armadeus Systems APF28Dev docking/development board";
> >       compatible = "armadeus,imx28-apf28dev", "armadeus,imx28-apf28", 
> > "fsl,imx28";
...
> > -
> >       regulators {
> >           compatible = "simple-bus";
> >           #address-cells = <1>;
> > @@ -223,3 +63,155 @@ user-button {
> >           };
> >       };
> >   };
> > +
> > +&auart0 {
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&auart0_pins_a>;
> > +    uart-has-rtscts;
> > +    status = "okay";
> > +};
> > +
> > +&can0 {
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&can0_pins_a>;
> > +    xceiver-supply = <&reg_can0_vcc>;
> > +    status = "okay";
> > +};
> > +
> > +&lcdif {
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&lcdif_16bit_pins_a
> > +            &lcdif_pins_apf28dev>;
> > +    display = <&display0>;
> > +    status = "okay";
> > +
> > +    display0: display0 {
> > +        bits-per-pixel = <16>;
> > +        bus-width = <16>;
> > +
> > +        display-timings {
> > +            native-mode = <&timing0>;
> > +            timing0: timing0 {
> > +                clock-frequency = <33000033>;
> > +                hactive = <800>;
> > +                vactive = <480>;
> > +                hback-porch = <96>;
> > +                hfront-porch = <96>;
> > +                vback-porch = <20>;
> > +                vfront-porch = <21>;
> > +                hsync-len = <64>;
> > +                vsync-len = <4>;
> > +                hsync-active = <1>;
> > +                vsync-active = <1>;
> > +                de-active = <1>;
> > +                pixelclk-active = <0>;
> > +            };
> > +        };
> > +    };
> > +};
> > +
> > +&lradc {
> > +    fsl,lradc-touchscreen-wires = <4>;
> > +    status = "okay";
> > +};
> > +
> > +&i2c0 {
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&i2c0_pins_a>;
> > +    status = "okay";
> > +};
>
> This i2c0 node should be before the lcdif node to have the nodes in 
> alphabetical order.
thanks for pointing out. I will fix this if this series is still wanted.
> Regards,
>
> > +
> > +&mac1 {
> > +    phy-mode = "rmii";
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&mac1_pins_a>;
> > +    phy-reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>;
> > +    status = "okay";
> > +};
> > +
> > +&pinctrl {
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&hog_pins_apf28dev>;
> > +
> > +    hog_pins_apf28dev: hog@0 {
> > +        reg = <0>;
> > +        fsl,pinmux-ids = <
> > +            MX28_PAD_LCD_D16__GPIO_1_16
> > +            MX28_PAD_LCD_D17__GPIO_1_17
> > +            MX28_PAD_LCD_D18__GPIO_1_18
> > +            MX28_PAD_LCD_D19__GPIO_1_19
> > +            MX28_PAD_LCD_D20__GPIO_1_20
> > +            MX28_PAD_LCD_D21__GPIO_1_21
> > +            MX28_PAD_LCD_D22__GPIO_1_22
> > +            MX28_PAD_GPMI_CE1N__GPIO_0_17
> > +        >;
> > +        fsl,drive-strength = <MXS_DRIVE_4mA>;
> > +        fsl,voltage = <MXS_VOLTAGE_HIGH>;
> > +        fsl,pull-up = <MXS_PULL_DISABLE>;
> > +    };
> > +
> > +    lcdif_pins_apf28dev: lcdif-apf28dev@0 {
> > +        reg = <0>;
> > +        fsl,pinmux-ids = <
> > +            MX28_PAD_LCD_RD_E__LCD_VSYNC
> > +            MX28_PAD_LCD_WR_RWN__LCD_HSYNC
> > +            MX28_PAD_LCD_RS__LCD_DOTCLK
> > +            MX28_PAD_LCD_CS__LCD_ENABLE
> > +        >;
> > +        fsl,drive-strength = <MXS_DRIVE_4mA>;
> > +        fsl,voltage = <MXS_VOLTAGE_HIGH>;
> > +        fsl,pull-up = <MXS_PULL_DISABLE>;
> > +    };
> > +
> > +    usb0_otg_apf28dev: otg-apf28dev@0 {
> > +        reg = <0>;
> > +        fsl,pinmux-ids = <
> > +            MX28_PAD_LCD_D23__GPIO_1_23
> > +        >;
> > +        fsl,drive-strength = <MXS_DRIVE_4mA>;
> > +        fsl,voltage = <MXS_VOLTAGE_HIGH>;
> > +        fsl,pull-up = <MXS_PULL_DISABLE>;
> > +    };
> > +};
>
> The pinctrl node is usually placed at the end of the file.
This confuses me, because this isn't alphabetical order anymore. I never 
heard of this.
> Thank you !
>
> Regards,
>
> > +
> > +&pwm {
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&pwm3_pins_a &pwm4_pins_a>;
> > +    status = "okay";
> > +};
> > +
> > +&ssp0 {
> > +    compatible = "fsl,imx28-mmc";
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&mmc0_4bit_pins_a
> > +        &mmc0_cd_cfg &mmc0_sck_cfg>;
> > +    bus-width = <4>;
> > +    status = "okay";
> > +};
> > +
> > +&ssp2 {
> > +    compatible = "fsl,imx28-spi";
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&spi2_pins_a>;
> > +    status = "okay";
> > +};
> > +
> > +&usb0 {
> > +    pinctrl-names = "default";
> > +    pinctrl-0 = <&usb0_otg_apf28dev
> > +            &usb0_id_pins_b>;
> > +    vbus-supply = <&reg_usb0_vbus>;
> > +    status = "okay";
> > +};
> > +
> > +&usb1 {
> > +    status = "okay";
> > +};
> > +
> > +&usbphy0 {
> > +    status = "okay";
> > +};
> > +
> > +&usbphy1 {
> > +    status = "okay";
> > +};