On 13/02/2023 10:50, Javier Carrasco wrote: > These RTCs are handled by the pcf85363 device driver, which now supports > the quartz-load-femtofarads property. > > Signed-off-by: Javier Carrasco <javier.carrasco@xxxxxxxxxxxxxx> > --- > .../devicetree/bindings/rtc/nxp,pcf8563.yaml | 20 ++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml > index a98b72752349..aac7f7565ba7 100644 > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml > @@ -9,9 +9,6 @@ title: Philips PCF8563/Epson RTC8564 Real Time Clock > maintainers: > - Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > > -allOf: > - - $ref: rtc.yaml# > - > properties: > compatible: > enum: > @@ -37,6 +34,23 @@ properties: > start-year: true > wakeup-source: true > > +allOf: > + - $ref: rtc.yaml# > + - if: > + properties: > + compatible: > + contains: > + enum: > + - nxp,pcf85263 > + - nxp,pcf85363 > + then: > + properties: > + quartz-load-femtofarads: > + description: > + The capacitive load of the quartz(x-tal). > + enum: [6000, 7000, 12500] > + default: 7000 I don't think this will work. If you tested your DTS, you would see errors. Please define the property in top-level and disallow it for other variants. Other way to make it working would be to switch to unevaluatedProperties, but defining properties in allOf:if:then: is not that readable. Best regards, Krzysztof
