On 11/02/2023 17:02, Daniel Golle wrote: > Convert mediatek,sgmiiisys bindings to DT schema format. > Add maintainer Matthias Brugger, no maintainers were listed in the > original documentation. > As this node is also referenced by the Ethernet controller and used > as SGMII PCS add this fact to the description. > Thank you for your patch. There is something to discuss/improve. > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.yaml > new file mode 100644 > index 000000000000..99ceb08ad7c0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/arm/mediatek/mediatek,sgmiisys.yaml#"; > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; Drop quotes from both. > + > +title: MediaTek SGMIISYS Controller > + > +maintainers: > + - Matthias Brugger <matthias.bgg@xxxxxxxxx> > + > +description: > + The MediaTek SGMIISYS controller provides SGMII related clocks to the system > + and is used by the Ethernet controller as SGMII PCS. > + > +properties: > + $nodename: > + pattern: "^syscon@[0-9a-f]+$" Drop nodename, we do not require it per binding. > + > + compatible: > + oneOf: Drop oneOf, unless you plan to use it soon? > + - items: > + - enum: > + - mediatek,mt7622-sgmiisys > + - mediatek,mt7629-sgmiisys > + - mediatek,mt7986-sgmiisys_0 > + - mediatek,mt7986-sgmiisys_1 > + - const: syscon > + Best regards, Krzysztof
