Thanks for the review. On Sun, Feb 12, 2023 at 05:00:24PM +0100, Krzysztof Kozlowski wrote: > Thank you for your patch. There is something to discuss/improve. Few nits. > > On 11/02/2023 22:04, Alain Volmat wrote: > > Addition of the various STi platform syscon node description. > > Use imperative. > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > > > > Signed-off-by: Alain Volmat <avolmat@xxxxxx> > > --- > > .../bindings/arm/sti/st,sti-syscon.yaml | 46 +++++++++++++++++++ > > 1 file changed, 46 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml > > > > diff --git a/Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml b/Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml > > new file mode 100644 > > index 000000000000..e4bbc90694b3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml > > @@ -0,0 +1,46 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/arm/sti/st,sti-syscon.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: STMicroelectronics STi platform sysconfig entries > > > Drop "entries", does not look related to hardware. > > > + > > +maintainers: > > + - Patrice Chotard <patrice.chotard@xxxxxxxxxxx> > > + > > +description: | > > + Binding for the various sysconfig nodes used within the STi > > + platform device-tree to point to some common configuration > > + registers used by other nodes. > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - st,stih407-sbc-syscfg > > + - st,stih407-front-syscfg > > + - st,stih407-rear-syscfg > > + - st,stih407-flash-syscfg > > + - st,stih407-sbc-reg-syscfg > > + - st,stih407-core-syscfg > > + - st,stih407-lpm-syscfg > > How about putting them in some order? Ok, changed to alphabet order > > > + - const: syscon > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + syscfg_sbc: sbc-syscfg@9620000 { > > Generic node names, thus usually syscon or system-controller Ok, changed to syscfg_sbc: syscon@9620000 I also move the file within bindings/soc/sti as mentioned in your other reply. > > +... > > Best regards, > Krzysztof >
