Hi, On Sat, 11 Feb 2023 at 13:38, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 10/02/2023 16:27, Neil Armstrong wrote: > > On 10/02/2023 16:16, Dmitry Baryshkov wrote: > >> On 10/02/2023 16:44, Neil Armstrong wrote: > >>> The SM8450 & SM350 shares the same DT TX IP version, use the > >>> SM8350 compatible as fallback for SM8450. > >>> > >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >>> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> > >>> --- > >>> .../bindings/display/msm/dp-controller.yaml | 25 +++++++++++++--------- > >>> 1 file changed, 15 insertions(+), 10 deletions(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > >>> index 0e8d8df686dc..f0c2237d5f82 100644 > >>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > >>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > >>> @@ -15,16 +15,21 @@ description: | > >>> properties: > >>> compatible: > >>> - enum: > >>> - - qcom,sc7180-dp > >>> - - qcom,sc7280-dp > >>> - - qcom,sc7280-edp > >>> - - qcom,sc8180x-dp > >>> - - qcom,sc8180x-edp > >>> - - qcom,sc8280xp-dp > >>> - - qcom,sc8280xp-edp > >>> - - qcom,sdm845-dp > >>> - - qcom,sm8350-dp > >>> + oneOf: > >>> + - enum: > >>> + - qcom,sc7180-dp > >>> + - qcom,sc7280-dp > >>> + - qcom,sc7280-edp > >>> + - qcom,sc8180x-dp > >>> + - qcom,sc8180x-edp > >>> + - qcom,sc8280xp-dp > >>> + - qcom,sc8280xp-edp > >>> + - qcom,sdm845-dp > >>> + - qcom,sm8350-dp > >>> + - items: > >>> + - enum: > >>> + - qcom,sm8450-dp > >>> + - const: qcom,sm8350-dp > >> > >> Neil, Krzysztof, I'm not convinced that this is worth all the troubles. I think it would be easier to have a flat list of compatibles and handle all the differences inside the driver. For example, for sdm845 we simply reused sc7180 config internally, while keeping separate compatible strings. > > > > Sure, but the doc reports the SM8350, SM8450 and SM550 has the exact same IP version, isn't fallback for that cat ? > > Exactly. > > What's the trouble with the list Neil created? No troubles. I felt that it fell out of the line, but no other issues. -- With best wishes Dmitry
