Le Fri, 10 Feb 2023 13:01:01 +0100, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> a écrit : > On 09/02/2023 16:16, Clément Léger wrote: > > Add "renesas,rzn1-gmac" binding documentation which is compatible with > > "snps,dwmac" compatible driver but uses a custom PCS to communicate > > with the phy. > > > > Signed-off-by: Clément Léger <clement.leger@xxxxxxxxxxx> > > --- > > .../bindings/net/renesas,rzn1-gmac.yaml | 67 +++++++++++++++++++ > > 1 file changed, 67 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml b/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml > > new file mode 100644 > > index 000000000000..029ce758a29c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml > > @@ -0,0 +1,67 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/renesas,rzn1-gmac.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Renesas GMAC > > + > > +maintainers: > > + - Clément Léger <clement.leger@xxxxxxxxxxx> > > + > > +select: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - renesas,r9a06g032-gmac > > + - renesas,rzn1-gmac > > + required: > > + - compatible > > + > > +allOf: > > + - $ref: snps,dwmac.yaml# > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - renesas,r9a06g032-gmac > > + - const: renesas,rzn1-gmac > > + - const: snps,dwmac > > Thanks, looks good now. > > > + > > + pcs-handle: > > + description: > > + phandle pointing to a PCS sub-node compatible with > > + renesas,rzn1-miic.yaml# > > + $ref: /schemas/types.yaml#/definitions/phandle > > you do not need ref here - it is coming from ethernet-controller.yaml > via snps,dwmac.yaml. You actually could drop entire property, but it can > also stay for the description. Ok thanks for the tip. I will drop it since there will be a v4. > > > + > > +required: > > + - compatible > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/r9a06g032-sysctrl.h> > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + > > + ethernet@44000000 { > > + compatible = "renesas,r9a06g032-gmac", "renesas,rzn1-gmac", "snps,dwmac"; > > + reg = <0x44000000 0x2000>; > > + interrupt-parent = <&gic>; > > + interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>, > > Please align with previous < > > > Best regards, > Krzysztof > -- Clément Léger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com
