On 10/02/2023 12:35, Sergio Paracuellos wrote: >>> - mt7621_wdt_reset = devm_reset_control_get_exclusive(dev, NULL); >>> - if (!IS_ERR(mt7621_wdt_reset)) >>> - reset_control_deassert(mt7621_wdt_reset); >>> + drvdata->sysc = syscon_regmap_lookup_by_phandle(np, "ralink,sysctl"); >>> + if (IS_ERR(drvdata->sysc)) >>> + return PTR_ERR(drvdata->sysc); >> >> You claim in commit title that you remove some global usage, but you add >> here several new features and refactor the code significantly. You need >> to split refactorings, improvements from completely new features. The >> entire patch is very difficult to understand in current form. > > I am removing global usage and architecture dependencies using a > watchdog driver data structure so I thought the changes were easy > enough to review in this way. It seems they are not according to your > reply :). If preferred I can split this in two commits: > - Avoid globals using and introducing all the related new driver data > structure. > - Add request for regmap syscon from the phandle and remove the > architecture dependent calls and includes. > Yes, such split sounds better. Thanks. Best regards, Krzysztof
